Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct implode() argument order #252

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Correct implode() argument order #252

merged 1 commit into from
Mar 19, 2020

Conversation

SharkyKZ
Copy link

@SharkyKZ SharkyKZ commented Dec 2, 2019

Summary of Changes

Corrects implode() argument order to fix notices in PHP 7.4.

Testing Instructions

Code review.

@alikon alikon mentioned this pull request Dec 28, 2019
Closed
@alikon
Copy link

alikon commented Dec 28, 2019

this should be merged before of yesterday....

tested successfully

@richard67 richard67 mentioned this pull request Jan 27, 2020
Closed
@roland-d roland-d merged commit c0a81f6 into joomla-extensions:master Mar 19, 2020
@SharkyKZ SharkyKZ deleted the php74/implode branch March 19, 2020 19:52
@roland-d roland-d added this to the 4.0.0 milestone Mar 20, 2020
roland-d added a commit that referenced this pull request Mar 20, 2020
@roland-d
Set correct argument order #252
e53009b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SharkyKZ @alikon @roland-d